Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate contracts v2.2.0 #1845

Merged
merged 66 commits into from
Oct 1, 2024
Merged

Integrate contracts v2.2.0 #1845

merged 66 commits into from
Oct 1, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Sep 4, 2024 •
edited
Loading

Fixes # .

Changes proposed in this PR:

  • integrated factory contract
  • updated contract version
  • created test script for sapphire

@mariacarmina mariacarmina self-assigned this Sep 4, 2024
alexcos20
alexcos20 requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

src/@types/NFTFactory.ts Outdated Show resolved Hide resolved
src/contracts/AccessList.ts Outdated Show resolved Hide resolved
src/contracts/AccessList.ts Outdated Show resolved Hide resolved
src/contracts/AccessList.ts Outdated Show resolved Hide resolved
src/contracts/AccessListFactory.ts Outdated Show resolved Hide resolved
src/contracts/NFT.ts Show resolved Hide resolved
test/integration/PublishEditConsume.test.ts Outdated Show resolved Hide resolved
test/config.ts Outdated Show resolved Hide resolved
@mariacarmina mariacarmina changed the base branch from integration-oasis to main September 24, 2024 08:56
@mariacarmina mariacarmina mentioned this pull request Sep 24, 2024
Closed
jamiehewitt15
jamiehewitt15 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

paulo-ocean
paulo-ocean approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariacarmina
Copy link
Member Author

@alexcos20 can you check this PR please?

@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 26, 2024

Code Climate has analyzed commit 2e02dfc and detected 21 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 16

Note: there is 1 critical issue.

The test coverage on the diff in this pull request is 52.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.7% (-0.7% change).

View more on Code Climate.

@mariacarmina mariacarmina merged commit a2861ef into main Oct 1, 2024
11 checks passed
@mariacarmina mariacarmina deleted the integrate-contracts-v2.2.0 branch October 1, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mariacarmina @alexcos20 @jamiehewitt15 @bogdanfazakas @paulo-ocean