wip: update compute status/stop to support agreementId, not documentId, sig fix
#1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ocean
requested review from
mihaisc,
alexcos20 and
bogdanfazakas
as code owners
…service, neither used on signature check
paulo-ocean
changed the title
agreementId, not documentIdagreementId, not documentId, sig fix
|
Looks like there is an issue with the integration test |
probably ipfs related, just timeouts... nothing really changed here anyway |
|
Code Climate has analyzed commit 4e0536a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 50.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1820 .
Changes proposed in this PR:
agreementIdon get compute job status (documentId is not used, onlyowner,jobIdoragreementId)