Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fs use & error handling #1777

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix fs use & error handling #1777

merged 4 commits into from
Oct 16, 2023

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Oct 6, 2023 •
edited
Loading

Fixes # .

Changes proposed in this PR:

  • removes fs use from config helper to prevent errors in browser context
  • update provider error handling helper method

@bogdanfazakas bogdanfazakas changed the title fix fs use fix fs use & error handling Oct 11, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 11, 2023

Code Climate has analyzed commit 40c22b9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 31.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.0%.

View more on Code Climate.

@bogdanfazakas bogdanfazakas marked this pull request as ready for review October 16, 2023 09:21
alexcos20
alexcos20 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdanfazakas bogdanfazakas merged commit 38cc028 into main Oct 16, 2023
@bogdanfazakas bogdanfazakas deleted the fix/fs-use branch October 16, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdanfazakas @alexcos20