Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Use custom addresses & fallback signature to legacy #1772

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Sep 19, 2023

Fixes #1768 #1767 .

Changes proposed in this PR:

  • fallback on signature
  • use env var addresses if available

@bogdanfazakas bogdanfazakas self-assigned this Sep 19, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit e7664d4 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.0% (1.0% change).

View more on Code Climate.

@bogdanfazakas bogdanfazakas marked this pull request as ready for review September 22, 2023 11:25
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I will test it with ocean.js-cli

@bogdanfazakas bogdanfazakas merged commit 8f28f3b into main Sep 25, 2023
@bogdanfazakas bogdanfazakas deleted the feature/custom-address-fallback-signature branch September 25, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom contract addresses
2 participants