Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert fetch require #169

Merged
merged 1 commit into from
Jul 17, 2020
Merged

revert fetch require #169

merged 1 commit into from
Jul 17, 2020

Conversation

kremalicious
Copy link
Contributor

@kremalicious kremalicious commented Jul 17, 2020 •
edited
Loading

Not sure what the right solution is to have browsers use window.fetch, either by solving it with build tool or using e.g. axios within WebServiceConnector, but for now we can simply try reverting that change from #165

@kremalicious
revert fetch require
e123db0 
reverting change from #165
@alexcos20 alexcos20 self-requested a review July 17, 2020 12:03
alexcos20
alexcos20 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kremalicious kremalicious merged commit f3ecb17 into develop Jul 17, 2020
@kremalicious kremalicious deleted the fix/fetch branch July 17, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kremalicious @alexcos20