Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Provider.checkFileUrl to allow non-URL file types (like Arweave) #1627

Merged
merged 15 commits into from
Oct 19, 2022
Merged

Update Provider.checkFileUrl to allow non-URL file types (like Arweave) #1627

merged 15 commits into from
Oct 19, 2022

Conversation

MantisClone
Copy link
Contributor

@MantisClone MantisClone commented Oct 1, 2022 •
edited
Loading

Required by oceanprotocol/market#1732

Changes proposed in this PR:

  • Update Provider.checkFileUrl API to take UrlFile | Arweave objects instead of a string which assumes type url.
  • Update Provider test

@MantisClone MantisClone marked this pull request as ready for review October 3, 2022 18:35
@MantisClone MantisClone marked this pull request as draft October 3, 2022 18:35
@LoznianuAnamaria LoznianuAnamaria mentioned this pull request Oct 6, 2022
Closed
@MantisClone MantisClone changed the title Arweave Integration Milestone 1: Publish using transaction ID Update Provider.checkFileUrl to allow non-URL file types Oct 7, 2022
@MantisClone MantisClone changed the title Update Provider.checkFileUrl to allow non-URL file types Update Provider.checkFileUrl to allow non-URL file types (like Arweave) Oct 7, 2022
@MantisClone MantisClone mentioned this pull request Oct 8, 2022
Closed
@MantisClone MantisClone marked this pull request as ready for review October 10, 2022 13:09
@MantisClone
Copy link
Contributor Author

Hello @alexcos20 @kremalicious @mihaisc @bogdanfazakas
I believe this PR is ready for your review.

CC @AnaLoznianu

@MantisClone
Copy link
Contributor Author

@kremalicious Thank you so much for your review! I have gone through and tried to address all of your concerns and I believe this PR is ready again for review.

CC @mihaisc @bogdanfazakas @AnaLoznianu

kremalicious
kremalicious approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go after lint fix, thanks for the patience!

@MantisClone
Copy link
Contributor Author

Thanks, @kremalicious for the quick 2nd review! I am unable to merge this myself because I do not have write access to the repo, so I invite you or any other core team member to merge it on my behalf.
image

@kremalicious kremalicious merged commit 6efae8e into oceanprotocol:main Oct 19, 2022
@MantisClone MantisClone deleted the arweave-integration branch October 19, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kremalicious kremalicious kremalicious approved these changes

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MantisClone @kremalicious