Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/contracts dependencies #150

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Fix/contracts dependencies #150

merged 2 commits into from
Jul 15, 2020

Conversation

0x3bfc
Copy link
Contributor

@0x3bfc 0x3bfc commented Jul 14, 2020

No description provided.

@kremalicious
Copy link
Contributor

haha, thanks, you were quick :-)

@kremalicious
Copy link
Contributor

kremalicious commented Jul 14, 2020

just a sec: not clear this is the right solution. It all depends on if the library should handle loading the correct artifacts so the frontends doesn't have to, or not

The current example tells developers to source the artifacts individually: https://github.com/oceanprotocol/ocean-lib-js/blob/develop/docs/README_marketplace_flow.md#2-alice-publishes-assets-for-data-services--publishes-a-datatoken-contract

This would imply users have to install @oceanprotocol/contracts on their own. If so, then they should be a peerDependency so devs are warned to install them on their own.

If the library should load the artifacts on its own, then @oceanprotocol/contracts can stay as proposed in this PR

@alexcos20
Copy link
Member

the libary should handle the artifacts, at least by having some default ones.
If a dev wants to extend it or work with another version of the contracts, then he/she should be able to do that

@0x3bfc 0x3bfc merged commit 4f4f9ab into develop Jul 15, 2020
@0x3bfc 0x3bfc deleted the fix/contracts-dependencies branch July 15, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants