Issue-#1343: Rewrite simple publish consume flow test

test/integration/SimplePublishConsumeFlow.test.ts

@@ -10,92 +10,95 @@ import {
   Datatoken,
   getHash,
   Nft,
-  downloadFile
+  downloadFile,
+  ZERO_ADDRESS
 } from '../../src'
-import { ProviderFees, Erc20CreateParams } from '../../src/@types'
-
-const assetUrl = [
-  {
-    type: 'url',
-    url: 'https://raw.githubusercontent.com/oceanprotocol/testdatasets/main/shs_dataset_test.txt',
-    method: 'GET'
-  }
-]
-const ddo = {
-  '@context': ['https://w3id.org/did/v1'],
-  id: 'did:op:efba17455c127a885ec7830d687a8f6e64f5ba559f8506f8723c1f10f05c049c',
-  version: '4.0.0',
-  chainId: 4,
-  nftAddress: '0x0',
-  metadata: {
-    created: '2021-12-20T14:35:20Z',
-    updated: '2021-12-20T14:35:20Z',
-    type: 'dataset',
-    name: 'dfgdfgdg',
-    description: 'd dfgd fgd dfg dfgdfgd dfgdf',
-    tags: [''],
-    author: 'dd',
-    license: 'https://market.oceanprotocol.com/terms',
-    additionalInformation: {
-      termsAndConditions: true
-    }
-  },
-  services: [
-    {
-      id: 'notAnId',
-      type: 'access',
-      files: '',
-      datatokenAddress: '0xa15024b732A8f2146423D14209eFd074e61964F3',
-      serviceEndpoint: 'https://providerv4.rinkeby.oceanprotocol.com',
-      timeout: 0
-    }
-  ]
-}
+import { ProviderFees, Erc20CreateParams, DDO } from '../../src/@types'
 
 describe('Simple Publish & consume test', async () => {
   let config: Config
   let addresses: any
   let aquarius: Aquarius
   let providerUrl: any
+  let publisherAccount: string
+  let consumerAccount: string
+
+  const assetUrl = [
+    {
+      type: 'url',
+      url: 'https://raw.githubusercontent.com/oceanprotocol/testdatasets/main/shs_dataset_test.txt',
+      method: 'GET'
+    }
+  ]
+
+  const ddo: DDO = {
+    '@context': ['https://w3id.org/did/v1'],
+    id: '',
+    version: '4.0.0',
+    chainId: 4,
+    nftAddress: '0x0',
+    metadata: {
+      created: '2021-12-20T14:35:20Z',
+      updated: '2021-12-20T14:35:20Z',
+      type: 'dataset',
+      name: 'dataset-name',
+      description: 'Ocean protocol test dataset description',
+      author: 'oceanprotocol-team',
+      license: 'MIT'
+    },
+    services: [
+      {
+        id: 'testFakeId',
+        type: 'access',
+        files: '',
+        datatokenAddress: '0x0',
+        serviceEndpoint: 'https://providerv4.rinkeby.oceanprotocol.com',
+        timeout: 0
+      }
+    ]
+  }
 
   before(async () => {
     config = await getTestConfig(web3)
-    addresses = getAddresses()
     aquarius = new Aquarius(config.metadataCacheUri)
     providerUrl = config.providerUri
+
+    addresses = getAddresses()
+  })
+
+  it('Initialize accounts', async () => {
+    const accounts = await web3.eth.getAccounts()
+    publisherAccount = accounts[0]
+    consumerAccount = accounts[1]
   })
 
   it('should publish a dataset (create NFT + ERC20)', async () => {
     const nft = new Nft(web3)
     const datatoken = new Datatoken(web3)
     const Factory = new NftFactory(addresses.ERC721Factory, web3)
-    const accounts = await web3.eth.getAccounts()
-    const publisherAccount = accounts[0]
-    const consumerAccount = accounts[1]
+
     const nftParams: NftCreateData = {
-      name: 'testNFT',
-      symbol: 'TST',
+      name: '72120Bundle',
+      symbol: '72Bundle',
       templateIndex: 1,
-      tokenURI: '',
+      tokenURI: 'https://oceanprotocol.com/nft/',
       transferable: true,
       owner: publisherAccount
     }
+
     const erc20Params: Erc20CreateParams = {
       templateIndex: 1,
       cap: '100000',
       feeAmount: '0',
-      paymentCollector: '0x0000000000000000000000000000000000000000',
-      feeToken: '0x0000000000000000000000000000000000000000',
+      paymentCollector: ZERO_ADDRESS,
+      feeToken: ZERO_ADDRESS,
       minter: publisherAccount,
-      mpFeeAddress: '0x0000000000000000000000000000000000000000'
+      mpFeeAddress: ZERO_ADDRESS
     }
-    const result = await Factory.createNftWithErc20(
-      publisherAccount,
-      nftParams,
-      erc20Params
-    )
-    const erc721Address = result.events.NFTCreated.returnValues[0]
-    const datatokenAddress = result.events.TokenCreated.returnValues[0]
+
+    const tx = await Factory.createNftWithErc20(publisherAccount, nftParams, erc20Params)
+    const erc721Address = tx.events.NFTCreated.returnValues[0]
+    const datatokenAddress = tx.events.TokenCreated.returnValues[0]
 
     // create the files encrypted string
     let providerResponse = await ProviderInstance.encrypt(assetUrl, providerUrl)
@@ -110,7 +113,7 @@ describe('Simple Publish & consume test', async () => {
     providerResponse = await ProviderInstance.encrypt(ddo, providerUrl)
     const encryptedResponse = await providerResponse
     const metadataHash = getHash(JSON.stringify(ddo))
-    const res = await nft.setMetadata(
+    await nft.setMetadata(
       erc721Address,
       publisherAccount,
       0,
@@ -120,10 +123,13 @@ describe('Simple Publish & consume test', async () => {
       encryptedResponse,
       '0x' + metadataHash
     )
+
     const resolvedDDO = await aquarius.waitForAqua(ddo.id)
     assert(resolvedDDO, 'Cannot fetch DDO from Aquarius')
+
     // mint 1 ERC20 and send it to the consumer
     await datatoken.mint(datatokenAddress, publisherAccount, '1', consumerAccount)
+
     // initialize provider
     const initializeData = await ProviderInstance.initialize(
       resolvedDDO.id,
@@ -132,6 +138,7 @@ describe('Simple Publish & consume test', async () => {
       consumerAccount,
       providerUrl
     )
+
     const providerFees: ProviderFees = {
       providerFeeAddress: initializeData.providerFee.providerFeeAddress,
       providerFeeToken: initializeData.providerFee.providerFeeToken,
@@ -142,6 +149,7 @@ describe('Simple Publish & consume test', async () => {
       providerData: initializeData.providerFee.providerData,
       validUntil: initializeData.providerFee.validUntil
     }
+
     // make the payment
     const txid = await datatoken.startOrder(
       datatokenAddress,
@@ -150,6 +158,7 @@ describe('Simple Publish & consume test', async () => {
       0,
       providerFees
     )
+
     // get the url
     const downloadURL = await ProviderInstance.getDownloadUrl(
       ddo.id,
@@ -160,9 +169,10 @@ describe('Simple Publish & consume test', async () => {
       providerUrl,
       web3
     )
+
     assert(downloadURL, 'Provider getDownloadUrl failed')
     try {
-      const fileData = await downloadFile(downloadURL)
+      await downloadFile(downloadURL)
     } catch (e) {
       assert.fail('Download failed')
     }