Replace toWei/fromWei when base token conversion #1318
Conversation
| @@ -366,10 +366,10 @@ export class FixedRateExchange { | |||
| const estGas = await this.estSetRate( | |||
| address, | |||
| exchangeId, | |||
| await this.unitsToAmount(exchange.baseToken, String(newRate)) | |||
| await this.amountToUnits(exchange.baseToken, String(newRate)) | |||
There was a problem hiding this comment.
this is what was used above so I used to be consistent
There was a problem hiding this comment.
strange, we always use toString, don't know how that stayed there.
There was a problem hiding this comment.
feel free to update all String(value) in other places if you find more of this 😃
| const estGas = await this.estSetRate( | ||
| address, | ||
| exchangeId, | ||
| this.web3.utils.toWei(String(newRate)) | ||
| await this.amountToUnits(exchange.baseToken, newRate.toString()) |
There was a problem hiding this comment.
this conversions should also take place in estSetRate() just pass the raw string values to the estimate method and convert them there also
|
I run into an issue when using When sending the rate to the contract it contains 6 zeros so
|
|
Code Climate has analyzed commit cee1bc2 and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 63.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 71.2% (-0.2% change). View more on Code Climate. |
Fixes #1279 .