Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fixed order params #1287

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix fixed order params #1287

merged 1 commit into from
Feb 14, 2022

Conversation

mihaisc
Copy link
Contributor

@mihaisc mihaisc commented Feb 14, 2022

No description provided.

kremalicious
kremalicious approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@kremalicious kremalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just assume it fixes my fixed price assets ordering so great! 😀

@mihaisc
Copy link
Contributor Author

mihaisc commented Feb 14, 2022

correct, i am amazed how it worked in my tests earlier this morning, and the ocean.js tests have no issue with this.

@mihaisc mihaisc merged commit de4dde3 into v4main Feb 14, 2022
@mihaisc mihaisc deleted the fix/freOrer branch February 14, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kremalicious kremalicious kremalicious approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaisc @kremalicious