Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users/market to set own gas contract options & configurable web3 contract params #1214

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Allow users/market to set own gas contract options & configurable web3 contract params #1214

merged 5 commits into from
Jan 20, 2022

Conversation

bogdanfazakas
Copy link
Member

Fixes #1106
Fixes #1107

Changes proposed in this PR:

  • added multiplier gas value as parameter in config and use it in the get fair gas price
  • added transactionPollingTimeout, transactionConfirmationBlocks & transactionBlockTimeout as parameter in config
  • updated codebase to use and set the default options in a similar way we had them in v3

alexcos20
alexcos20 approved these changes Jan 20, 2022
View reviewed changes
src/models/Config.ts Outdated Show resolved Hide resolved
src/utils/ContractUtils.ts Outdated Show resolved Hide resolved
src/utils/ContractUtils.ts Outdated Show resolved Hide resolved
src/utils/ContractUtils.ts Outdated Show resolved Hide resolved
@bogdanfazakas bogdanfazakas merged commit 5621b43 into v4main Jan 20, 2022
@bogdanfazakas bogdanfazakas deleted the feature/own-gas-contract-options branch January 20, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

@kremalicious kremalicious Awaiting requested review from kremalicious

@mihaisc mihaisc Awaiting requested review from mihaisc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdanfazakas @alexcos20