Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releases #1021

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Fix releases #1021

merged 2 commits into from
Sep 14, 2021

Conversation

kremalicious
Copy link
Contributor

@kremalicious kremalicious commented Sep 14, 2021

2 automatic updates were leading to faulty release publish flow (which we don't test in our CI so we didn't catch it) so lock them down again. Tried refactoring to run those scripts with Typescript and ts-node but lots of new problems as we then need e.g. #570

  • roll back to ora v5.4.1 & typedoc v0.21.9
  • more loose web3 peerDependencies
  • add npm run doc:json to CI build test, so it should™ fail when dependabot pushes us a new dependency PR for those

@codeclimate
Copy link

codeclimate bot commented Sep 14, 2021

Code Climate has analyzed commit 96490b6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.0% (0.0% change).

View more on Code Climate.

@kremalicious kremalicious merged commit 09ca007 into main Sep 14, 2021
@kremalicious kremalicious deleted the fix/publish branch September 14, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants