remove asset sample link if not send on metadata update

oceanprotocol · Feb 8, 2021 · 3608472 · 3608472
1 parent c417fc4
commit 3608472
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/ocean/Assets.ts b/src/ocean/Assets.ts
@@ -260,8 +260,11 @@ export class Assets extends Instantiable {
       if (newMetadata.description)
         ddo.service[i].attributes.additionalInformation.description =
           newMetadata.description
-      if (newMetadata.links)
+      if (newMetadata.links) {
         ddo.service[i].attributes.additionalInformation.links = newMetadata.links
+      } else {
+        ddo.service[i].attributes.additionalInformation.links = []
+      }
     }
     return ddo
   }

diff --git a/test/integration/Marketplaceflow.test.ts b/test/integration/Marketplaceflow.test.ts
@@ -226,6 +226,25 @@ describe('Marketplace flow', () => {
     assert.deepEqual(metaData.attributes.additionalInformation.links, newMetaData.links)
   })
 
+  it('Alice updates metadata and removes sample links', async () => {
+    const newMetaData: EditableMetadata = {
+      description: 'new description no links',
+      title: 'new title no links'
+    }
+    const newDdo = await ocean.assets.editMetadata(ddo, newMetaData)
+    assert(newDdo !== null)
+    const txid = await ocean.onChainMetadata.update(newDdo.id, newDdo, alice.getId())
+    assert(txid !== null)
+    await sleep(60000)
+    const metaData = await ocean.assets.getServiceByType(ddo.id, 'metadata')
+    assert.equal(metaData.attributes.main.name, newMetaData.title)
+    assert.equal(
+      metaData.attributes.additionalInformation.description,
+      newMetaData.description
+    )
+    assert.deepEqual(metaData.attributes.additionalInformation.links, [])
+  })
+
   it('Alice updates timeout for the access service', async () => {
     const service = ddo.findServiceByType('access')
     assert(service !== null)