Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix corner case issue, cannot start indexing on ganache without ADDRESS_FILE #775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix corner case issue, cannot start indexing on ganache without ADDRESS_FILE #775

wants to merge 2 commits into from

Conversation

paulo-ocean
Copy link
Contributor

Fixes #773

Changes proposed in this PR:

  • Make sure we always assign a default start block for ganache, even if we forget the env setting

@paulo-ocean paulo-ocean self-assigned this Dec 4, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review December 4, 2024 14:52
jamiehewitt15
jamiehewitt15 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indexer - Minor - Unable to index local network (ganache) if we forget about ADDRESS_FILE
2 participants
@paulo-ocean @jamiehewitt15