Fix DecryptDdoHandler #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipMasar
requested review from
bogdanfazakas,
jamiehewitt15,
mariacarmina and
paulo-ocean
as code owners
paulo-ocean
approved these changes
May 28, 2024
There was a problem hiding this comment.
LGTM,
nevertheless i think we should try to provide a better description of the issue, in this case is not critical since the change is minimal, but it looks like the issue is that we cannot "decrypt" a DDO when the transaction id provided was generated by some metadata "updated" event... and we're only expecting a metadata "created" event...
The provided description:
"When DDO metadata was updated, it was not updated in ocean-node" is a bit vague IMO, seems like we did not processed the event on the indexer/db or something, instead
thanks
alexcos20
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes edit DDO
When DDO metadata was updated, it was not updated in ocean-node