Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add detail status handler, small refactor #395

Merged
merged 5 commits into from
Apr 23, 2024
Merged

add detail status handler, small refactor #395

merged 5 commits into from
Apr 23, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Apr 18, 2024 •
edited
Loading

Fixes #41

Changes proposed in this PR:

  • add some more fields to the status request (via new handler), extending previous one
  • refactor/reduce handler validation chunk (rate limits and Command params) + add missing ones

@paulo-ocean paulo-ocean marked this pull request as ready for review April 19, 2024 13:09
bogdanfazakas
bogdanfazakas approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jamiehewitt15
jamiehewitt15 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit c5dfad7 into develop Apr 23, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-41-detail-status branch April 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15