Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove swagger deps #386

Merged
merged 2 commits into from
Apr 8, 2024
Merged

remove swagger deps #386

merged 2 commits into from
Apr 8, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Apr 5, 2024 •
edited
Loading

Fixes #343 .

Changes proposed in this PR:

  • Remove the swagger deps and references (so we keep the .md files instead)
  • too much effort just trying to configure it, and would be a huge task to document all from scratch in a proper way

@paulo-ocean paulo-ocean marked this pull request as ready for review April 5, 2024 16:05
bogdanfazakas
bogdanfazakas approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit 8c45d46 into develop Apr 8, 2024
5 of 6 checks passed
@paulo-ocean paulo-ocean deleted the issue-343-swagger branch April 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15