Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ Check proper order tx #370

Merged
merged 13 commits into from
Apr 8, 2024
Merged

Fix/ Check proper order tx #370

merged 13 commits into from
Apr 8, 2024

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Mar 21, 2024 •
edited
Loading

Fixes #351 .

Changes proposed in this PR:

  • added checks for each event on User Address, NFT address and Datatoken address

@bogdanfazakas bogdanfazakas changed the base branch from main to develop March 21, 2024 10:48
@bogdanfazakas bogdanfazakas self-assigned this Mar 25, 2024
@bogdanfazakas bogdanfazakas marked this pull request as ready for review March 25, 2024 14:05
@paulo-ocean
Copy link
Contributor

paulo-ocean commented Mar 25, 2024 •
edited
Loading

hey @bogdanfazakas this is a bit confusing with the stuff from the other PR :-) ...
what are the changes related with this PR only? i already approved the other
thanks

paulo-ocean
paulo-ocean approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mariacarmina
mariacarmina reviewed Apr 3, 2024
View reviewed changes
src/test/integration/download.test.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
mariacarmina
mariacarmina approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdanfazakas bogdanfazakas merged commit af09474 into develop Apr 8, 2024
6 checks passed
@bogdanfazakas bogdanfazakas deleted the fix/check-proper-order-tx branch April 8, 2024 06:14
@bogdanfazakas bogdanfazakas mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

Assignees

@bogdanfazakas bogdanfazakas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security: Order transactions
3 participants
@bogdanfazakas @paulo-ocean @mariacarmina