Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop node handler #329

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Stop node handler #329

merged 8 commits into from
Mar 12, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Mar 11, 2024 •
edited
Loading

Fixes #292 .

Changes proposed in this PR:

  • add stop node handler
  • validate signature for auth when using directCommand endpoint
  • added timeout for process.exist()

@mariacarmina mariacarmina self-assigned this Mar 11, 2024
@mariacarmina mariacarmina marked this pull request as ready for review March 11, 2024 11:33
mariacarmina
mariacarmina commented Mar 11, 2024
View reviewed changes
Copy link
Member Author

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @alexcos20

src/components/core/dashboard.ts Outdated Show resolved Hide resolved
paulo-ocean
paulo-ocean reviewed Mar 12, 2024
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
jamiehewitt15
jamiehewitt15 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

paulo-ocean
paulo-ocean approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariacarmina mariacarmina merged commit 2be4f05 into develop Mar 12, 2024
6 checks passed
@mariacarmina mariacarmina deleted the stop-node-command branch March 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariacarmina @bogdanfazakas @jamiehewitt15 @paulo-ocean