Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created function for retriving datatoken decimals. #264

Merged
merged 43 commits into from
Mar 19, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Feb 14, 2024

Fixes #262 .

Changes proposed in this PR:

  • added util function for datatoken decimals retrieval
  • fix amounts to convert to specified token decimals
  • modified downloadTask for checkFee function which now receives chainID as parameter

Unit tests are failing due to insertLog TypeError, which is fixed by @paulo-ocean in another PR. Moved fees.test.ts inside integration, because we use contracts interaction (and requires barge & contracts).

@mariacarmina mariacarmina self-assigned this Feb 14, 2024
@mariacarmina mariacarmina marked this pull request as ready for review February 19, 2024 12:08
src/utils/blockchain.ts Show resolved Hide resolved
src/test/integration/fees.test.ts Outdated Show resolved Hide resolved
src/test/integration/fees.test.ts Outdated Show resolved Hide resolved
src/@types/commands.ts Outdated Show resolved Hide resolved
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean
Copy link
Contributor

@mariacarmina
check the test about 'feesData.v' (on comments above)
Its not correct yet. It should be:
assert( feesData.v === 27 || feesData.v === 28, 'Expected feesData.v to be 27 or 28')
tkx

@mariacarmina
Copy link
Member Author

@mariacarmina check the test about 'feesData.v' (on comments above) Its not correct yet. It should be: assert( feesData.v === 27 || feesData.v === 28, 'Expected feesData.v to be 27 or 28') tkx

Fixed a lot of conflicts and now fees.test.ts file does not exist, can you point to the line of code that you are referring to in Files Changed tab? Thanks

@paulo-ocean
Copy link
Contributor

@mariacarmina check the test about 'feesData.v' (on comments above) Its not correct yet. It should be: assert( feesData.v === 27 || feesData.v === 28, 'Expected feesData.v to be 27 or 28') tkx

Fixed a lot of conflicts and now fees.test.ts file does not exist, can you point to the line of code that you are referring to in Files Changed tab? Thanks

The file was deleted

src/utils/blockchain.ts Outdated Show resolved Hide resolved
@mariacarmina mariacarmina merged commit b697f0f into develop Mar 19, 2024
6 checks passed
@mariacarmina mariacarmina deleted the datatoken-decimals branch March 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants