Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move commands from constants.ts to @types/commands.ts #244

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Move commands from constants.ts to @types/commands.ts #244

merged 4 commits into from
Jan 29, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #214

Changes proposed in this PR:

  • Move all Commands interfaces/types outside utils/constants.ts to own @types/commands.ts

@paulo-ocean paulo-ocean changed the title move commands from constants.ts to @types/commands.ts Move commands from constants.ts to @types/commands.ts Jan 25, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review January 25, 2024 14:44
@paulo-ocean paulo-ocean self-assigned this Jan 25, 2024
jamiehewitt15
jamiehewitt15 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good. This makes more sense

bogdanfazakas
bogdanfazakas approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needed refactor :)

@paulo-ocean paulo-ocean merged commit be0cde4 into develop Jan 29, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-214-command-types branch January 29, 2024 12:37
@paulo-ocean paulo-ocean mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@an7e an7e Awaiting requested review from an7e

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15