-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create collections specific for ddo versions #225
Conversation
Should I also modify |
I see what you mean there is some overlap between the two issues. I think it's fine to do it in the next PR, which keeps this one short and easy to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariacarmina please take a couple of minutes before rushing the commits :-)
If an exception is caught on the outer try/catch (have no idea why we need both but anyway)
The function returns nothing, it just logs a message, it should return empty array as well to be consistent
tkx
I return now empty array in the outer try/catch block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for approvals, but @alexcos20 needs to undo the requested changes status in order to merge it 😅 |
Fixes #207 .
Changes proposed in this PR: