Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ocean node class #175

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Improve ocean node class #175

merged 6 commits into from
Dec 19, 2023

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Dec 18, 2023 •
edited
Loading

Fixes #136

Changes proposed in this PR:

  • refactor OceanNode class a bit
  • add handlers registry support

(eventually will need some refactor once we finish #171 to connect the dots)

@paulo-ocean paulo-ocean changed the base branch from main to develop December 18, 2023 22:45
@paulo-ocean paulo-ocean marked this pull request as ready for review December 19, 2023 10:24
bogdanfazakas
bogdanfazakas approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit 7c0d826 into develop Dec 19, 2023
6 checks passed
@paulo-ocean paulo-ocean deleted the improve-ocean-node-class branch December 19, 2023 15:26
@paulo-ocean paulo-ocean mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@an7e an7e Awaiting requested review from an7e

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance OceanNode class
3 participants
@paulo-ocean @alexcos20 @bogdanfazakas