-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch setup mocha tests #104
Conversation
wrong PR :-( and branch |
@paulo-ocean typesense tests are failing for the moment using mocha? |
|
I saw that you rewrite the tests, but I think it was easier for you to merge the config part and we could rewrite on our end as well (to avoid extra work). Can I also contribute on that branch https://github.com/oceanprotocol/ocean-node/tree/other-test-branch? |
@mariacarmina that is just a testing branch that i created for my testing purposes. Its not to be merged anywhere and we should not work on it.. that's for me to understand if mocha would solve all our import issues, with all the tests we have at the moment... nothing else |
Thanks for clarifying @paulo-ocean. If I can contribute for this issue with mocha as test framework, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, i've run the tests suite also locally and all seems to be fine
Fixes # .
Changes proposed in this PR:
It seems to be working properly. We have failing tests, that we will have to fix,
but the issues with the import of the modules apparently are gone.
Needs a little more check, but i think we're on the right track
UPDATE: these tests are all passing now