Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch setup mocha tests #104

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Branch setup mocha tests #104

merged 3 commits into from
Nov 14, 2023

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Nov 9, 2023

Fixes # .

Changes proposed in this PR:

  • add mocha as test framework

It seems to be working properly. We have failing tests, that we will have to fix,
but the issues with the import of the modules apparently are gone.
Needs a little more check, but i think we're on the right track

UPDATE: these tests are all passing now

@paulo-ocean paulo-ocean closed this Nov 9, 2023
@paulo-ocean
Copy link
Contributor Author

wrong PR :-( and branch

@paulo-ocean paulo-ocean reopened this Nov 9, 2023
@paulo-ocean paulo-ocean changed the base branch from main to develop November 9, 2023 18:37
@mariacarmina
Copy link
Member

@paulo-ocean typesense tests are failing for the moment using mocha?

@paulo-ocean
Copy link
Contributor Author

@paulo-ocean typesense tests are failing for the moment using mocha?
Hi @mariacarmina , yes, many still fail, but not because of the framework.
For instance, some fail because we don't have the collections or the documents on the db
mocha seems to work fine, in what concerns to the ES module imports..
as another example, i created this other test branch https://github.com/oceanprotocol/ocean-node/tree/other-test-branch where i put together all the tests we have from different PRs and branches ... and i re-write them to use mocha functions instead of jest...
And i can run them all, using mocha without any import issues..
Sure, many tests fail, but because we need to fix them, not because of the framework imports

@mariacarmina
Copy link
Member

I saw that you rewrite the tests, but I think it was easier for you to merge the config part and we could rewrite on our end as well (to avoid extra work). Can I also contribute on that branch https://github.com/oceanprotocol/ocean-node/tree/other-test-branch?

@paulo-ocean
Copy link
Contributor Author

paulo-ocean commented Nov 10, 2023

I saw that you rewrite the tests, but I think it was easier for you to merge the config part and we could rewrite on our end as well (to avoid extra work). Can I also contribute on that branch https://github.com/oceanprotocol/ocean-node/tree/other-test-branch?

@mariacarmina that is just a testing branch that i created for my testing purposes. Its not to be merged anywhere and we should not work on it.. that's for me to understand if mocha would solve all our import issues, with all the tests we have at the moment... nothing else
The one we are going to merge would be this one here :-)
branch-setup-mocha-tests
once i make the PR official, and then would be to each one to fix their own tests coming from other PRs, branches, etc.. with the new mocha framework
cheers

@mariacarmina
Copy link
Member

Thanks for clarifying @paulo-ocean. If I can contribute for this issue with mocha as test framework, please let me know.

@paulo-ocean paulo-ocean marked this pull request as ready for review November 10, 2023 16:17
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i've run the tests suite also locally and all seems to be fine

@paulo-ocean paulo-ocean merged commit 99f6feb into develop Nov 14, 2023
@alexcos20 alexcos20 deleted the branch-setup-mocha-tests branch January 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants