Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass config argument when we have it #84

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

paulo-ocean
Copy link
Contributor

Fixes #82

Changes proposed in this PR:

  • pass argument config and/or network to sdk. avoid sdk errors

@paulo-ocean paulo-ocean self-assigned this Jan 9, 2025
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 7112ba0 into main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid SDK errors when a valid config or network is not provided to a given SC class constructor
2 participants