-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compute history #958
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/8EdfLAqP1F5d6ztSQUz4hhFUHRxc |
Not sure if this is ready for review yet? All the tests are failing |
You're right. Converted it into draft until the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked over the code and it looks fine. The deployment has failed though, so can't check the preview
Thanks, @jamiehewitt15 for checking it. Yes, seems to have a problem with the next.js. @mihaisc when you have some time could you please give me some insight of how this can be fixed, is the same problem like the one in the publishers with most sales PR |
Code Climate has analyzed commit e8372ba and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO NOT MERGE !!!!! I will merge it after we deploy the remaining components on main c2d
Fixes #853 .
Changes proposed in this PR:
status
function without signing it, removed 'Get Results' buttongetResults
function signing for each result file