Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compute history #958

Merged
merged 10 commits into from
Dec 15, 2021
Merged

Update compute history #958

merged 10 commits into from
Dec 15, 2021

Conversation

claudiaHash
Copy link
Contributor

Fixes #853 .

Changes proposed in this PR:

  • used status function without signing it, removed 'Get Results' button
  • used getResults function signing for each result file

@vercel
Copy link

vercel bot commented Dec 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/8EdfLAqP1F5d6ztSQUz4hhFUHRxc
✅ Preview: https://market-git-feature-issue853-update-compte-history-oceanprotocol.vercel.app

@jamiehewitt15
Copy link
Member

Not sure if this is ready for review yet? All the tests are failing

@claudiaHash claudiaHash marked this pull request as draft December 10, 2021 08:17
@claudiaHash
Copy link
Contributor Author

Not sure if this is ready for review yet? All the tests are failing

You're right. Converted it into draft until the CredentialType import is resolved

@claudiaHash claudiaHash marked this pull request as ready for review December 10, 2021 13:05
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over the code and it looks fine. The deployment has failed though, so can't check the preview

@claudiaHash
Copy link
Contributor Author

claudiaHash commented Dec 10, 2021

The deployment has failed though, so can't check the preview

Thanks, @jamiehewitt15 for checking it. Yes, seems to have a problem with the next.js. @mihaisc when you have some time could you please give me some insight of how this can be fixed, is the same problem like the one in the publishers with most sales PR

@mihaisc
Copy link
Contributor

mihaisc commented Dec 10, 2021

Only issue is that you don't get a proper pointer when you hover over the link , it's not the hand thingy
image

@codeclimate
Copy link

codeclimate bot commented Dec 13, 2021

Code Climate has analyzed commit e8372ba and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@mihaisc mihaisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE !!!!! I will merge it after we deploy the remaining components on main c2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update compute history(C2D breaking changes)
3 participants