-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fetch free price #634
Update fetch free price #634
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/FoTQWRMsoL6xtsz4YXmvjcAkb7cN |
Code Climate has analyzed commit 5f037e2 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
@mihaisc seems like wallet need to be connected first. |
That is not ok, the market needs to work without a wallet |
again, not an option. Every user coming first to our app has no wallet connected |
@mihaisc @kremalicious Seems like the |
@alexcos20 do we have different versions of subgraph on main and testnets? |
i found 2 free assets that you published on rinkeby, can't order any of them. And the button should be https://market-qcwavxbd1-oceanprotocol.vercel.app/asset/did:op:8CE4EAF329A6618d554DBc0936791FF0DD5dF5cd |
I moved that comment here #654 , got a bit confused between them. Think it should have been just one pr. |
ok so it seems this is fixed in the other pr |
I think we can close this since it's merged in the other pr. |
ok sure. I will update the other PR (#654) with the detail in. |
Close #605
Changes proposed in this PR:
Pending: