Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch free price #634

Conversation

krisliew
Copy link
Contributor

@krisliew krisliew commented May 31, 2021

Close #605

Changes proposed in this PR:

  • Fetch free pricing asset

image

Pending:

@vercel
Copy link

vercel bot commented May 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/FoTQWRMsoL6xtsz4YXmvjcAkb7cN
✅ Preview: https://market-git-feature-update-fetch-price-free-f92721-oceanprotocol.vercel.app

@krisliew krisliew self-assigned this May 31, 2021
@krisliew krisliew marked this pull request as ready for review June 3, 2021 05:35
@codeclimate
Copy link

codeclimate bot commented Jun 7, 2021

Code Climate has analyzed commit 5f037e2 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@krisliew krisliew changed the base branch from main to feature/epic-free-pricing June 8, 2021 06:48
@mihaisc
Copy link
Contributor

mihaisc commented Jun 8, 2021

home page fails to load, am i missing something?
image

@kremalicious
Copy link
Contributor

quick UI feedback, current UI has too many 0's and currencies and labels when in reality it just needs one "Free":

Screen Shot 2021-06-08 at 11 33 31

Also the button then can't say "Buy" as the asset is free.

@krisliew
Copy link
Contributor Author

krisliew commented Jun 8, 2021

home page fails to load, am i missing something?

@mihaisc seems like wallet need to be connected first.

@mihaisc
Copy link
Contributor

mihaisc commented Jun 8, 2021

That is not ok, the market needs to work without a wallet

@kremalicious
Copy link
Contributor

seems like wallet need to be connected first.

again, not an option. Every user coming first to our app has no wallet connected

@krisliew
Copy link
Contributor Author

krisliew commented Jun 8, 2021

@mihaisc @kremalicious Seems like the dispenser is not added in the mainnet subgraph query which is causing the errors. https://subgraph.mainnet.oceanprotocol.com/subgraphs/name/oceanprotocol/ocean-subgraph/graphql

@mihaisc
Copy link
Contributor

mihaisc commented Jun 8, 2021

@alexcos20 do we have different versions of subgraph on main and testnets?

@mihaisc
Copy link
Contributor

mihaisc commented Jun 11, 2021

i found 2 free assets that you published on rinkeby, can't order any of them. And the button should be Order not Buy

https://market-qcwavxbd1-oceanprotocol.vercel.app/asset/did:op:8CE4EAF329A6618d554DBc0936791FF0DD5dF5cd
image

@krisliew
Copy link
Contributor Author

@mihaisc ah my bad, for the "buy" button and order it is done at this PR #654
For the "0 Ocean" at algorithm list, I will update that in a bit.

@mihaisc
Copy link
Contributor

mihaisc commented Jun 11, 2021

I moved that comment here #654 , got a bit confused between them. Think it should have been just one pr.

@mihaisc
Copy link
Contributor

mihaisc commented Jun 11, 2021

i found 2 free assets that you published on rinkeby, can't order any of them. And the button should be Order not Buy

https://market-qcwavxbd1-oceanprotocol.vercel.app/asset/did:op:8CE4EAF329A6618d554DBc0936791FF0DD5dF5cd
image

ok so it seems this is fixed in the other pr

@mihaisc
Copy link
Contributor

mihaisc commented Jun 11, 2021

I think we can close this since it's merged in the other pr.

@krisliew
Copy link
Contributor Author

I think we can close this since it's merged in the other pr.

ok sure. I will update the other PR (#654) with the detail in.

@krisliew krisliew closed this Jun 11, 2021
@krisliew krisliew deleted the feature/update-fetch-price-free-pricing branch June 11, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fetch price to include free pricing schema
3 participants