Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add provider uri and timeouts to publish form #272

Closed
wants to merge 2 commits into from
Closed

add provider uri and timeouts to publish form #272

wants to merge 2 commits into from

Conversation

azenyem
Copy link

@azenyem azenyem commented Nov 24, 2020 •
edited by kremalicious
Loading

addressing #202

@vercel
Copy link

vercel bot commented Nov 24, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/ae0bnjk1p
✅ Preview: https://market-git-feature-provider-and-timeouts.oceanprotocol.vercel.app

@kremalicious kremalicious marked this pull request as draft November 30, 2020 11:40
kremalicious
kremalicious reviewed Dec 3, 2020
View reviewed changes
src/components/molecules/FormFields/DurationInput/index.tsx
}, [field])
return (
<>
<InputGroup customClass="duration-input-group">
Copy link
Contributor

@kremalicious kremalicious Dec 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<InputGroup customClass="duration-input-group">
<InputGroup className={styles.durationInputGroup}>

@kaimeinke kaimeinke mentioned this pull request Dec 30, 2020
Closed
@alexcos20 alexcos20 linked an issue Jan 8, 2021 that may be closed by this pull request
Need to set a Custom Timout of Consumption of Datasets #306
Closed
@alexcos20 alexcos20 mentioned this pull request Jan 8, 2021
Closed
@kremalicious
Copy link
Contributor

kremalicious commented Jan 12, 2021 •
edited
Loading

Since this is already rather old, I would suggest closing this and addressing only #202 as a separate new PR. The timeout editing is way more important than exposing the provider URL right now

@kremalicious kremalicious deleted the feature/provider-and-timeouts branch September 24, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kremalicious kremalicious kremalicious left review comments

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 will be requested when the pull request is marked ready for review jamiehewitt15 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas will be requested when the pull request is marked ready for review bogdanfazakas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to set a Custom Timout of Consumption of Datasets
2 participants
@azenyem @kremalicious