Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GA4 #2040

Merged
merged 1 commit into from
May 26, 2024
Merged

feat: add GA4 #2040

merged 1 commit into from
May 26, 2024

Conversation

tom1145
Copy link
Collaborator

@tom1145 tom1145 commented May 22, 2024

Fixes #2027.

Changes proposed in this PR:

  • add GA4 and enable cookie banner

image

@tom1145 tom1145 self-assigned this May 22, 2024
@tom1145 tom1145 linked an issue May 22, 2024 that may be closed by this pull request
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:17am

Copy link

codeclimate bot commented May 22, 2024

Code Climate has analyzed commit bb7a8e0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2% (0.0% change).

View more on Code Climate.

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the readme. This line is no longer true for example:

This feature is disabled per default since we do not use cookies requiring consent on our deployment of the market

@mihaisc mihaisc merged commit 0a8e72a into main May 26, 2024
11 checks passed
@mihaisc mihaisc deleted the 2027-add-ga4 branch May 26, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GA4
3 participants