Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hidden field type on edit form load #1993

Merged

Conversation

EnzoVezzaro
Copy link
Contributor

Changes proposed in this PR:

  • fix hidden field type on edit form when page is loading

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dubai-challenge ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 9:28am

@jamiehewitt15
Copy link
Member

I don't think I have ever experienced the hidden field type issue before, can you suggest some steps for replicating the issue and testing this?

@EnzoVezzaro
Copy link
Contributor Author

EnzoVezzaro commented Nov 8, 2023

I don't think I have ever experienced the hidden field type issue before, can you suggest some steps for replicating the issue and testing this?

Well, I don't think you'll be able to replicate it after this fix, but you can try what I commented here.

  • Open a file you have in edit mode
  • Open console and go on your nework tab
  • Set "slow 3g"
  • Refresh

You can try this on the main branch and compare the behaviour with this PR.

@jamiehewitt15
Copy link
Member

Something seems to have broken on this branch, when trying to open one of my assets the app crashes. I'm able to open the same asset on the main branch without any problems.

image

…eature/issue-1949-fix-file-input-low-connectivity
Copy link

codeclimate bot commented Nov 15, 2023

Code Climate has analyzed commit a6fa333 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2% (0.0% change).

View more on Code Climate.

@jamiehewitt15
Copy link
Member

Something seems to have broken on this branch, when trying to open one of my assets the app crashes. I'm able to open the same asset on the main branch without any problems.

Looks like that issue has already been solved on main. It's not happening anymore after pulling the latest changes from main

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me now

@jamiehewitt15 jamiehewitt15 merged commit 4ced71c into main Nov 15, 2023
13 checks passed
@jamiehewitt15 jamiehewitt15 deleted the feature/issue-1949-fix-file-input-low-connectivity branch November 15, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File input not always populated in edit form
2 participants