Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom provider error handling #1965

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Sep 18, 2023

Fixes #1966 .

Changes proposed in this PR:

  • fixes error handling for isValid and isCompatible custom provider input field
  • revert some input changes from consumer params pr

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 10:12am
odc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 10:12am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dubai-challenge ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 10:12am

@bogdanfazakas bogdanfazakas marked this pull request as draft September 18, 2023 08:43
@codeclimate
Copy link

codeclimate bot commented Sep 18, 2023

Code Climate has analyzed commit 5186f5a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 30.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2%.

View more on Code Climate.

@bogdanfazakas bogdanfazakas marked this pull request as ready for review September 18, 2023 10:55
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Works without any issues.

@bogdanfazakas bogdanfazakas merged commit a976e5b into main Sep 25, 2023
13 checks passed
@bogdanfazakas bogdanfazakas deleted the fix-custom-provider-error-handling branch September 25, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when using custom provider
2 participants