Have latest version as an aqua default. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calina-c
requested review from
alexcos20,
kremalicious,
mihaisc and
ssallam
as code owners
trentmc
approved these changes
Mar 26, 2021
|
sure is easier but it implies that from now on integration tests in other repos will break by default whenever we introduce breaking change in aquarius, forcing them to update their codebase, or start hardcoding versions themselves. That was the point of slowing this process down and do it manually for each version but yeah, it's an overhead when no breaking changes are introduced. In any case, the version table in the readme needs to have the version number removed then too |
alexcos20
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aqua was hardcoded to 2.2.4 in barge. Need to have
latestinstead.Is this PR related with an open issue?
Related to Issue oceanprotocol/ocean.py#255
Types of changes