Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update price and change orderCount calcs. #862

Merged
merged 11 commits into from
Aug 12, 2022
Merged

Update price and change orderCount calcs. #862

merged 11 commits into from
Aug 12, 2022

Conversation

calina-c
Copy link
Contributor

Work on #853.

@mihaisc
Copy link

mihaisc commented Jul 26, 2022

Also please add dispensers ( i forgot to mention in the initial issue) . We need to add the dispenser created event and add dispensers{id} in the query. The condition would be something like this if it has a fre the price = fre.price , if it has a dispenser price = 0, if error price =-1

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2022

Code Climate has analyzed commit 66fb48e and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 95.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.4% (0.2% change).

View more on Code Climate.

@calina-c calina-c marked this pull request as ready for review July 27, 2022 08:40
@calina-c calina-c requested review from alexcos20 and mihaisc July 27, 2022 08:41
@LoznianuAnamaria LoznianuAnamaria linked an issue Aug 9, 2022 that may be closed by this pull request
@mihaisc
Copy link

mihaisc commented Aug 10, 2022

"Small" change request for this. In the meantime we added support for multiple tokens so we need to change price into an object :

"price": {
      "value" : 33,
      "tokenAddress": "0x0....",
      "tokenSymbol": "ocean"
}

To get this information add to the fixed rate query :

  baseToken
    {
      symbol
      address
    }

Copy link

@mihaisc mihaisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@calina-c calina-c merged commit 6e1e880 into main Aug 12, 2022
@calina-c calina-c deleted the update-pricing branch August 12, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add price in stats
2 participants