Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore nft state during EVENT_METADATA_STATE processing #837

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

soonhuat
Copy link
Contributor

@soonhuat soonhuat commented Jul 1, 2022

Description

When processing EVENT_METADATA_STATE, if previous nft state are not active, allow to change to the new nft state.

Is this PR related with an open issue?

Related to Issue #836

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@soonhuat soonhuat requested a review from a team as a code owner July 1, 2022 02:53
@alexcos20
Copy link
Member

Can you add tests as well ?
We are trying to have at least 90% coverage :)

@soonhuat
Copy link
Contributor Author

soonhuat commented Jul 1, 2022

Can you add tests as well ? We are trying to have at least 90% coverage :)

sure, let me add it in a while

@soonhuat
Copy link
Contributor Author

soonhuat commented Jul 7, 2022

@calina-c wonder if u could help take a look, I added test to re-active after "Ordering is temporary disabled"

@codeclimate
Copy link

codeclimate bot commented Jul 7, 2022

Code Climate has analyzed commit 63b8f1d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 38.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.5% (-0.2% change).

View more on Code Climate.

@calina-c calina-c merged commit 0811b02 into oceanprotocol:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants