-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for chain ID #1034
Add check for chain ID #1034
Conversation
I don't understand the idea behind this PR. Aquarius is multichain, why is there one NETWORK CONFIG URL instead of the multichain defined ones? Alternately, why do we need this variable if we have NETWORK URL? |
NETWORK CONFIG URL is an envvar to compare with event monitor chain. NETWORK CONFIG URL can be a public RPC which points to the same network as EVENTS RPC. It was an incident when our production RPCs for mumbai indexed blocks from polygon mainnet & a check for chain ID could solve the problem by stopping Aquarius from indexing blocks. |
I think you can use the network url. |
Code Climate has analyzed commit 271ca2d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 84.4% (0.0% change). View more on Code Climate. |
Description
Add check for chain ID. Added a new env var
CONFIG_NETWORK_URL
.Is this PR related with an open issue?
Related to Issue #1032
Types of changes
Checklist: