-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aquarius is returning outdated information about STRDOL-44 #419
Comments
I spent some time today trying to debug this issue. Unfortunately, I wasn't able to successfully breakpoint it. |
FYI to inform priority here: STRDOL-44 has been showing wrong information through Aquarius on rugpullindex.com since the opening of this issue. I'm tempted to manually remove it from my crawl but I'd prefer if Aquarius fixed it. It also shows bogus stats on the market website that may lead investors to lose money Clearly, there's not $5M of liquidity. A short-term workaround could be to temporarily add it to the purgatory list until the bug is resolved. Anyways, pls fix. |
I proposed a temporary removal in list-purgatory: oceanprotocol/list-purgatory#42 |
I am currently blocked on this issue but am seeking help from other team members. |
looks like aquarius was not processing the last EXIT event (https://etherscan.io/tx/0x8077b81c002d729623ac1e66286495f6a8212a48ce19db4aa43fc8baca9a8a0a) and kept the old values |
so multiple things were leading to the
If Aquarius can be easily made into showing correct numbers, we might release a new version, but in general we are moving away from having price info in the DDO completely. It was always a workaround, never standardized, and will not fit our multi-pool future anyway, so it was decided to scale back Aquarius to what it was supposed to be, a cache for the metadata standardized in our DDO schema. Which is why in last months we slowly replaced pretty much all numbers displayed in |
OK fair, then I'll start using the subgraph too. |
Since I'm new to the team, I would require hands-on help from other team members to further debug this issue. However, in light of the quote above, I think our time could be better spent on other tasks. I propose that this issue be marked "won't fix" or whatever the team convention is. |
thanks 👍🏼 |
Consider the URL: https://aquarius.mainnet.oceanprotocol.com/api/v1/aquarius/assets/ddo/did:op:FcB258F7084d2E075270C0D4B1E79a3113E11837 that returns meta data for STRDOL-44 or https://market.oceanprotocol.com/asset/did:op:FcB258F7084d2E075270C0D4B1E79a3113E11837.
Here's the full response:
Note that for the only pool https://etherscan.io/address/0xe13ecbE18440aD471c3C0b095d87a212D5C7EdCb, it shows
where as, when checking etherscan, the pool contains
Maybe it's me that has been doing this wrong all along, but I thought that "ocean" represented the total liquidity of Ocean in a pool. I'm now confused for two reasons:
As a sanity check, I also downloaded QUIRCA-0 from aquarius and double-checked its pool: https://aquarius.mainnet.oceanprotocol.com/api/v1/aquarius/assets/ddo/did:op:7Bce67697eD2858d0683c631DdE7Af823b7eea38
Comparing it to the value on Etherscan, I can confirm that they match my expectations. So I'm guessing that's a bug?
The text was updated successfully, but these errors were encountered: