-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated packages in Python environment #63
Conversation
…to problem with pip dependencies
Lets just go a cross post this: #42 (comment)
I don't think I'm going to be able convert to a mamba/micromamba based image before this event, and if there are any issues the cross-language debugging might be messy so it's probably better not to try. |
py-base/environment.yml
Outdated
# PyPI package is older, | ||
# but installing from github leads to conda-lock error | ||
# - git+https://github.com/open-ocean-sounding/echopy.git | ||
- echopy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package does not install its dependencies and pip installing it will bring a broken pkg, or not fully functioning at best. I sent conda-forge/staged-recipes#22020 PR to help out a bit with its installation. It is only missing one optional dependency as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
py-base/environment.yml
Outdated
@@ -94,3 +102,8 @@ dependencies: | |||
- xgcm | |||
- xlrd | |||
- zarr | |||
- pip: | |||
# PyPI package is older, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the history in the upstream repo there are no functional changes in the actual package since the last PyPI release. You should be OK with it. See https://github.com/open-ocean-sounding/echopy/commits/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
How about if I remove |
@abkfenris and @ocefpaf The current Python image includes |
I don't have an issue swapping it out, especially since Pandas supports using it. |
Thanks. I forgot that openpyxl doesn't support reading |
PS: I would also drop the conda-lock.yml file here b/c we only create the Linux lock anyway. You can do it with |
py-base/environment.yml
Outdated
- zarr | ||
# - pip: | ||
# - echopy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in conda-forge now. You can try it out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
I've removed Regarding |
Alright, I've re-created the conda environment (again with mamba) now with the new conda-forge |
Thanks! |
Added a few packages (contextily, folium, rioxarray, pip, and the pip package
echopy
), including two language packs (spanish & portuguese). Updatedpangeo-notebook
to 2023.02.11.Tried to update conda-lock but ran into problem with pip dependencies.
See #42 (comment), oceanhackweek/Hub-Management#2 and oceanhackweek/Hub-Management#3