feat: mobile build configs #51
Merged
+1,565
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing build ios raw deprecated
removing extra theo command
eltongarbin
force-pushed
the
mobile-build-configs
branch
from
8356e81 to
93a495c
Compare
eltongarbin
added
enhancement
Fixing wrong category name to discard
luisfernandezbr
suggested changes
Jul 9, 2020
Comment on lines
+1
to
+11
| module.exports = [ | ||
| 'src/color/index.yml', | ||
| 'src/border/index.yml', | ||
| 'src/opacity/index.yml', | ||
| 'src/radius/index.yml', | ||
| 'src/shadow/index.yml', | ||
| 'src/spacing/inline.yml', | ||
| 'src/spacing/inset.yml', | ||
| 'src/spacing/stack.yml', | ||
| 'src/typography/index.yml', | ||
| ]; |
There was a problem hiding this comment.
@eltongarbin @AlexGomesBlu
Do we still need these files? Or is it possible to use the exclusion rule using discardedCategories?
There was a problem hiding this comment.
web doesn't need this file.
There was a problem hiding this comment.
@luisfernandezbr Will the discardedCategories always be the same for both mobile platforms?
AlexGomesBlu
approved these changes
Jul 9, 2020
eltongarbin
force-pushed
the
mobile-build-configs
branch
from
adb174c to
031494e
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
eltongarbin
force-pushed
the
mobile-build-configs
branch
from
031494e to
7f638b6
Compare
willoliveira
approved these changes
Jul 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 75f92d1 and detected 0 issues on this pull request. View more on Code Climate. |
luisfernandezbr
approved these changes
Jul 10, 2020
| @@ -0,0 +1,5 @@ | |||
| module.exports = (name) => (fn) => { | |||
| const f = (...args) => fn(...args); | |||
There was a problem hiding this comment.
The variable f could be have a better semantic name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some refactors and improvements from #49 .
If you want to validate the output access this link