Notify LSP of workspace config when starting

[EduardoRFS]

Context

Currently the extension doesn't notify the LSP of configurations, this means that since ocaml/ocaml-lsp#1134 codelens are disabled whenever you start VSCode, even if you explicitly opt-in to codelens.

This is also true for disabling dune diagnostics like #1320.

Warning

This PR enables codelens again by default, as they're enabled in the manifest of the extension, I feel like this may be desirable anyway so I didn't change it, but if the extension wants to disable it by default, is just a matter of changing this https://github.com/ocamllabs/vscode-ocaml-platform/blob/master/package.json#L267

Related

• Add ocaml.server.duneDiagnostics to disable dune diagnostics reporting #1320

[EduardoRFS]

It seems like this is the old method of sending configurations.

This pull model replaces the old push model were the client signaled configuration change via an event. If the server still needs to react to configuration changes (since the server caches the result of workspace/configuration requests) the server should register for an empty configuration change using the following registration pattern:

It's likely that supporting this is a good idea as old LSPs are still gonna be working.

[voodoos]

Could you split the PR in two parts ? First the "send config on start fix" and then the new configuration option.

Thanks

[EduardoRFS]

Done, also pushed changelog

[EduardoRFS]

@smorimoto as you're already here can we get this reviewed and hopefully merged?

[smorimoto]

Let me just take a look at this! 🙂

[smorimoto]

At least to me this looks a right fix.

[rgrinberg]

@mnxn or @ulugbekna could you review this?

[rgrinberg]

Please don't use optional arguments unless there's a specific reason

[EduardoRFS]

My bad, was just copying the pattern from somewhere else in the codebase.

LanguageClient.OcamllspSettings.create

But now that I think about it, this is a binding and that's likely the reason why it is using optional parameters.

[rgrinberg]

LanguageClient.OcamllspSettings.create

That one is weird as well. It's our own private API, what's it doing inside the vscode API bindings?

But now that I think about it, this is a binding and that's likely the reason why it is using optional parameters.

What do you mean by "binding"?

[rgrinberg]

Ditto

[mnxn]

mnxn or ulugbekna could you review this?

Logic looks fine.
Style-wise, the Option.map + OcamllspSettingEnable.create code in send_configuration is a bit repetitive since it's repeated for each parameter. Especially since the master branch now has a third setting from #1320. Perhaps it could be abstracted into a helper function in a future PR.