Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension crashing after restarting the language server #1262

Merged
merged 1 commit into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

# Unreleased

- Fix extension crashing after restarting the language server (#1262)

## 1.13.3

- Set the VSCode lower bound to 1.82.0 and set the build target to es2022 to get
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ module StaticFeature = struct
( capabilities:ServerCapabilities.t
-> documentSelector:DocumentSelector.t or_undefined
-> unit)
-> dispose:(unit -> unit)
-> clear:(unit -> unit)
-> unit
-> t
[@@js.builder]]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ module StaticFeature : sig
( capabilities:ServerCapabilities.t
-> documentSelector:DocumentSelector.t or_undefined
-> unit)
-> dispose:(unit -> unit)
-> clear:(unit -> unit)
-> unit
-> t
end
Expand Down
4 changes: 2 additions & 2 deletions src/extension_instance.ml
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ end = struct
(Some experimental)
in
let initialize ~capabilities:_ ~documentSelector:_ = () in
let dispose () = () in
let clear () = () in
LanguageClient.StaticFeature.make
~fillClientCapabilities
~initialize
~dispose
~clear
()

let start_language_server t =
Expand Down