resolve command: don't select directories #5606
Merged
+114
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
force-pushed
the
system-process-dir
branch
from
7d81070 to
9653132
Compare
This was
linked to
issues
Jul 24, 2023
kit-ty-kate
approved these changes
Jul 24, 2023
This is needed for Windows environment, in order to have the good separator
rjbou
force-pushed
the
system-process-dir
branch
from
9653132 to
c5cd699
Compare
|
Removed new test on windows (unix only) until ocaml/dune#8651 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 different fixes, that can't be split. It fixes #5585, #5650, #5626, and partially #5597, as it fixes command resolve that is it happen to be a directory. I also add a test for that, and to have the test working, reftest engine needs a fix. It was keeping duplicated environment variables in environment given as argument to process creation, and it was not expanding
PATHon variable export.It also add syntax to declare env vars paths additions
PATH+=path/toorPATH=+path/to, to make it portable between unix & windows (:versus;).Todo: