init: detect local cygwin installation #5544
Merged
+650
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
PR: QUEUED
This was referenced May 10, 2023
rjbou
force-pushed
the
cygwin-local-detection
branch
3 times, most recently
from
090c3d3 to
8bd2321
Compare
AltGr
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
The interaction and detection mechanisms look good, but I think we need to be extra clear with what exactly we are asking the user (in particular paths, etc.) and in what context.
It may (in time ;) ) be the first interaction with OCaml of ppl not very familiar with the command-line so we need to be extra careful.
rjbou
added
PR: NEEDS UPDATE
PR: QUEUED
rjbou
force-pushed
the
cygwin-local-detection
branch
from
8bd2321 to
441ab53
Compare
rjbou
removed
the
PR: QUEUED
rjbou
force-pushed
the
cygwin-local-detection
branch
from
441ab53 to
cfed1d7
Compare
…g cygwin binary path
…cygwin binary location, and add a function to test directly if given cygwin installation path is a cygwin installation std: Sys.get_windows_executable_variant, use cygenv to get environment & quote cygcheck std: Update Sys.get_windows_executable_variant naming Co-authored-by: Raja Boujbel <[email protected]>
… when defined Co-authored-by: Raja Boujbel <[email protected]>
…t/setup.exe to opamroot/.cygwin/setup.exe
…ion given a binary path and a Cygwin setup executable path It also copies Cygwin setup in Cygwin root path, to be able to find it immediately next time Co-authored-by: David Allsopp <[email protected]>
rjbou
force-pushed
the
cygwin-local-detection
branch
from
cfed1d7 to
6a650f7
Compare
|
Some examples Menu with a pre-existent cygwin and defaults
Menu with specified cygwin & setup location
Menu with no pre-existent cygwin installation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At init && reinit, add detection and setup of a pre-existent cygwin installation.
It contains commit of #5543 (see #5543 (comment))
TODO