Fix cleaning up switch on error on Windows #5351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch lock needs to be dropped prior to erasing the switch on Windows.
rjbou
approved these changes
Nov 21, 2022
|
TODO note - it's possible that this can be done while taking the write lock, but using |
|
The approach in #5435 is better than this one (since the lock is then held right up to the deletion) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If switch creation fails and the user elects to clean-up the switch, there is at present an error message displayed when the switch is erased. This is caused by the write lock on the switch still being held. The fix is to drop the switch lock prior to deletion - the global lock is still held.