Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden doc/man/dune #4264

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Harden doc/man/dune #4264

merged 2 commits into from
Jul 10, 2020

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jul 8, 2020

Two fixes:

  • Building the man pages should never inexplicably block the build
  • There's a check to ensure that %{bin:opam} refers to something that's just been built and not something in PATH

cc @kit-ty-kate (replaces commit in #4229)

dra27 added 2 commits July 10, 2020 09:43
If the topics files are out-of-date, opam may be invoked with a
sub-command it doesn't recognise which will cause the plugin prompt to
be displayed.
Harden against the public_name of opamMain.exe being altered.
@rjbou rjbou force-pushed the harden-man-dune branch from 7b7bbd9 to aa57a1e Compare July 10, 2020 07:46
@rjbou rjbou added this to the 2.1.0~alpha2 milestone Jul 10, 2020
@rjbou rjbou merged commit 37caa1b into ocaml:master Jul 10, 2020
@rjbou
Copy link
Collaborator

rjbou commented Jul 10, 2020

Thanks!

@dra27 dra27 deleted the harden-man-dune branch July 14, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants