Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag packages with missing depexts to the solver #4235

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Jun 18, 2020

to allow playing with criteria and seeing if we can solve the
mariadb/mysql dilemma.

With this patch, you can add a -count[missing-depexts,solution]
criterion (putting it before the main version-lag criteria would be a
bad idea though).

@rjbou
Copy link
Collaborator

rjbou commented Jun 18, 2020

Tested in simple case

$ opam show foo -f depends # bmake is installed in the system, but no llvm
"ocaml"  ("conf-bmake" | "conf-llvm")

$ ./opam install foo.0.4 --show
The following actions would be performed:
  ∗ install conf-llvm 10.0.0 [required by foo]
  ∗ install foo       0.4
===== ∗ 2 =====

The following system packages will first need to be installed:
    llvm-10-dev

$ ./opam install foo.0.4 --show '--criteria=-removed,-count[version-lag,request],-count[missing-depexts,solution],-count[version-lag,changed],-changed'
The following actions would be performed:
  ∗ install conf-bmake 1.0 [required by foo]
  ∗ install foo        0.4
===== ∗ 2 =====

@rjbou rjbou added this to the 2.1.0~alpha2 milestone Jun 18, 2020
@rjbou rjbou added the PR: WIP Not for merge at this stage label Jun 25, 2020
AltGr added 2 commits July 2, 2020 16:18
to allow playing with criteria and seeing if we can solve the
mariadb/mysql dilemma.

With this patch, you can add a `-count[missing-depexts,solution]`
criterion (putting it before the main `version-lag` criteria would be a
bad idea though).
@AltGr AltGr force-pushed the depext-criterion branch from ad4ab08 to 6c16a37 Compare July 2, 2020 14:19
@rjbou rjbou removed the PR: WIP Not for merge at this stage label Jul 10, 2020
@rjbou rjbou merged commit 6b7305e into ocaml:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants