Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump compat releases (for 4.09.0 with dune 2.3.0) #4098

Closed
wants to merge 2 commits into from
Closed

Bump compat releases (for 4.09.0 with dune 2.3.0) #4098

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2020

Same as #4097, but against master.

@ghost
Copy link
Author

ghost commented Feb 23, 2020

This diff is the same as #4097, but it fails to build src_ext/cmdliner for some reason, even though no such error happens in #4097. I suspect a difference between master and 2.0, not sure what. Any ideas?

@dra27
Copy link
Member

dra27 commented Feb 23, 2020

2.0 shouldn’t have deps bumped until it’s absolutely necessary (cmdliner was already lagging)

@ghost
Copy link
Author

ghost commented Feb 24, 2020

It's what I had to change to make it work, but I know it's tricky to support a wide range of OCaml switches. @dra27, let's continue the discussion in #4097, if you don't mind.

@AltGr AltGr added this to the Next milestone Mar 9, 2020
@rjbou rjbou removed this from the Next milestone May 20, 2020
@rjbou rjbou mentioned this pull request May 22, 2020
Closed
@rjbou rjbou mentioned this pull request Jun 29, 2020
Merged
@dra27
Copy link
Member

dra27 commented Jul 1, 2020

This is superseded by #4257

@dra27 dra27 closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: NEEDS UPDATE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dra27 @AltGr @rjbou