Remove lint warning 56

OPAM_LAST_ENV means that it's no longer necessary to limit setenv to compiler packages.
ocaml · Jan 19, 2023 · 7946515 · 7946515
1 parent cbefeda
commit 7946515
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -147,6 +147,7 @@ users)
   * [BUG] Fix linting packages from repository with tarred repositories, the file in temporary repository was no more avaiable when lint is done [#5068 @rjbou]
   * Update repository package filename display [#5068 @rjbou]
   * E67: check checksums only for vcs urls [#4960 @rjbou]
+  * W56: detection removed, since `OPAM_LAST_ENV` allows reliable reverting [#5417 @dra27]
 
 ## Repository
   * When several checksums are specified, instead of adding in the cache only the archive by first checksum, name by best one and link others to this archive [#4696 rjbou]

diff --git a/src/state/opamFileTools.ml b/src/state/opamFileTools.ml
@@ -646,9 +646,13 @@ let t_lint ?check_extra_files ?(check_upstream=false) ?(all=false) t =
                       used norm)
                   bad_os_arch_values)
        (bad_os_arch_values <> []));
+    (* Retired, since `OPAM_LAST_ENV` allows environment updates to be reliably
+       reverted. *)
+(*
     cond 56 `Warning
       "It is discouraged for non-compiler packages to use 'setenv:'"
       (t.env <> [] && not (has_flag Pkgflag_Compiler t));
+*)
     cond 57 `Error
       "Synopsis and description must not be both empty"
       (t.descr = None || t.descr = Some OpamFile.Descr.empty);