Package dates_calc.0.0.7

[rmonat]

dates_calc.0.0.7

A date calculation library
A date calculation library, with exact operators to add a given
number of days to a date, and approximate operators to add months or
years.

---

• Homepage: https://github.com/CatalaLang/dates-calc
• Source repo: git+https://github.com/CatalaLang/dates-calc.git
• Bug tracker: https://github.com/CatalaLang/dates-calc/issues

---

🐫 Pull-request generated by opam-publish v2.3.0

[raphael-proust]

Are the test failures due to the mismatch of python version?

It works on some distros (e.g., arch with python 3.12) but not on others (e.g., debian with python 3.9).

#   File "/home/opam/.opam/5.2/.opam-switch/build/dates_calc.0.0.7/_build/default/lib_python/src/dates_calc/dates.py", line 43
#     match month:
#           ^
# SyntaxError: invalid syntax

Don't know if you want to do anything about it. I think it's ok to merge and expect users to manage their python environment (although I'd recommend documenting the requirement somewhere).

[rmonat]

Are the test failures due to the mismatch of python version?

It works on some distros (e.g., arch with python 3.12) but not on others (e.g., debian with python 3.9).

#   File "/home/opam/.opam/5.2/.opam-switch/build/dates_calc.0.0.7/_build/default/lib_python/src/dates_calc/dates.py", line 43
#     match month:
#           ^
# SyntaxError: invalid syntax

Don't know if you want to do anything about it. I think it's ok to merge and expect users to manage their python environment (although I'd recommend documenting the requirement somewhere).

Yes, this is pattern matching introduced by a recent Python version > 3.9. I would be in favor of merging as-is please!

[yawaramin]

@rmonat is there any reason to require conf-python-3 for this package? The functionality of the OCaml package does not depend on Python, if I understand correctly? If an OCaml/opam user wants to use the OCaml dates_calc library, they don't really need Python, right?

If so, I would suggest removing the Python dependency for submission to opam-repository and if the user needs to use the Python version of the package, they can install it using their Python tooling which they would need to manage anyway to ensure they have the required minimum version.

[rmonat]

@yawaramin thank you for your suggestion! The tests dune runs are for all languages: C, Python -- so having conf-python-3 would be nice, although we would indeed require a higher version.

[yawaramin]

Understood, I just want to avoid dependency bloat down the line. If some packages and projects in the future use this, their entire dependency cone would be pulling in Python despite it not being needed at all. I understand that you are using dune to run the Python library tests, but it seems like we should be able to find another way instead of forcing potential users of this package to install Python.

[mseri]

An option could be to disable the tests here, or to make a separate package for the python tests (in the same repo) that runs only on the package CI and not here.

[rmonat]

@mseri I totally agree! I removed the dependency for this release, and will do this in a future release.

Thank you for spotting this too!

[mseri]

Suggested change

	"@runtest" {with-test}
	# "@runtest" {with-test} # require python 3.12 to run

[mseri]

To disable them but run the non-pythonic ones here, what you could do is

• add a dates_calc_python_test.opam file, whose only purpose will be to run the python tests
  _ add (package dates_calc_python_test) to `test/dune

Then on release you only release dates_calc