-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix revdeps from Yojson PR #26009
Merged
Merged
Fix revdeps from Yojson PR #26009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They all fail with a variation of ``` === ERROR while compiling safemoney.0.1.1 ====================================# context 2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.5.2.0 | file:///home/opam/opam-repository path ~/.opam/5.2/.opam-switch/build/safemoney.0.1.1 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p safemoney -j 255 @install @runtest exit-code 1 env-file ~/.opam/log/safemoney-7-875a72.env output-file ~/.opam/log/safemoney-7-875a72.out File "test/dune", line 3, characters 43-60: 3 | (libraries safemoney_lib base core zarith ppx_expect.common ppx_expect.config ppx_expect.config_types stdint angstrom yojson) ^^^^^^^^^^^^^^^^^ Error: Library "ppx_expect.common" not found. -> required by library "safemoney_test" in _build/default/test -> required by _build/default/test/.safemoney_test.inline-tests/inline_test_runner_safemoney_test.exe -> required by alias test/runtest in test/dune:4 ``` Signed-off-by: Marcello Seri <[email protected]>
It was failing with `cppo: command not found` Probably it used to get it transitively Signed-off-by: Marcello Seri <[email protected]>
``` === ERROR while compiling guardian.0.1.0 =====================================# context 2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository path ~/.opam/4.14/.opam-switch/build/guardian.0.1.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p guardian -j 31 --promote-install-files=false @install exit-code 1 env-file ~/.opam/log/guardian-7-f51419.env output-file ~/.opam/log/guardian-7-f51419.out File "lib/dune", line 5, characters 32-38: 5 | (libraries containers logs lwt result uuidm) ^^^^^^ Error: Library "result" not found. -> required by library "guardian" in _build/default/lib -> required by _build/default/META.guardian -> required by _build/install/default/lib/guardian/META -> required by _build/default/guardian.install -> required by alias install ``` Signed-off-by: Marcello Seri <[email protected]>
I think |
mseri
commented
Jun 3, 2024
mseri
commented
Jun 3, 2024
mseri
commented
Jun 3, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25994
Failures in commits