Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revdeps from Yojson PR #26009

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Fix revdeps from Yojson PR #26009

merged 4 commits into from
Jun 3, 2024

Conversation

mseri
Copy link
Member

@mseri mseri commented Jun 3, 2024

See #25994
Failures in commits

mseri added 3 commits June 3, 2024 10:20
They all fail with a variation of
```
=== ERROR while compiling safemoney.0.1.1 ====================================#
 context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.5.2.0 | file:///home/opam/opam-repository
 path                 ~/.opam/5.2/.opam-switch/build/safemoney.0.1.1
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p safemoney -j 255 @install @runtest
 exit-code            1
 env-file             ~/.opam/log/safemoney-7-875a72.env
 output-file          ~/.opam/log/safemoney-7-875a72.out
 File "test/dune", line 3, characters 43-60:
 3 |  (libraries safemoney_lib base core zarith ppx_expect.common ppx_expect.config ppx_expect.config_types stdint angstrom yojson)
                                                ^^^^^^^^^^^^^^^^^
 Error: Library "ppx_expect.common" not found.
 -> required by library "safemoney_test" in _build/default/test
 -> required by
    _build/default/test/.safemoney_test.inline-tests/inline_test_runner_safemoney_test.exe
 -> required by alias test/runtest in test/dune:4
```

Signed-off-by: Marcello Seri <[email protected]>
It was failing with `cppo: command not found`
Probably it used to get it transitively

Signed-off-by: Marcello Seri <[email protected]>
```
=== ERROR while compiling guardian.0.1.0 =====================================#
 context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
 path                 ~/.opam/4.14/.opam-switch/build/guardian.0.1.0
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p guardian -j 31 --promote-install-files=false @install
 exit-code            1
 env-file             ~/.opam/log/guardian-7-f51419.env
 output-file          ~/.opam/log/guardian-7-f51419.out
 File "lib/dune", line 5, characters 32-38:
 5 |  (libraries containers logs lwt result uuidm)
                                     ^^^^^^
 Error: Library "result" not found.
 -> required by library "guardian" in _build/default/lib
 -> required by _build/default/META.guardian
 -> required by _build/install/default/lib/guardian/META
 -> required by _build/default/guardian.install
 -> required by alias install
```

Signed-off-by: Marcello Seri <[email protected]>
@Leonidas-from-XIV
Copy link
Contributor

I think sarif and safemonkey need to have their ppx_expect dependency to be capped at < v0.17 since ppx_expect.common existed in v0.16 but is gone in v0.17.

packages/sarif/sarif.0.1.0/opam Outdated Show resolved Hide resolved
packages/sarif/sarif.0.2.0/opam Outdated Show resolved Hide resolved
@mseri
Copy link
Member Author

mseri commented Jun 3, 2024

Thanks!

@mseri mseri merged commit 8ab79f8 into ocaml:master Jun 3, 2024
1 of 2 checks passed
@mseri mseri deleted the yojson-revdeps branch June 3, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants