Mark core_unix.v0.17.0 as unavailable on more architectures
#25977
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build failure on ppc64 and s390x is the following: /usr/bin/ld: /home/opam/.opam/5.2/lib/core_unix/time_stamp_counter/libtime_stamp_counter_stubs.a(time_stamp_counter_stubs.o): in function `caml_rdtsc_unboxed': /home/opam/.opam/5.2/.opam-switch/build/core_unix.v0.17.0/_build/default/time_stamp_counter/src/time_stamp_counter_stubs.c:51: undefined reference to `rdtsc' /usr/bin/ld: /home/opam/.opam/5.2/lib/core_unix/time_stamp_counter/libtime_stamp_counter_stubs.a(time_stamp_counter_stubs.o): in function `caml_rdtsc': /home/opam/.opam/5.2/.opam-switch/build/core_unix.v0.17.0/_build/default/time_stamp_counter/src/time_stamp_counter_stubs.c:56: undefined reference to `rdtsc' collect2: error: ld returned 1 exit status
|
I thought about flipping the condition but at current it also excludes x86_32 which I guess maps to |
|
Hi, thanks for reporting! Let's keep |
This prevents issues with new platforms added for which the C stubs will not generate the `rdtsc` function. Signed-off-by: Marek Kubica <[email protected]>
|
Thanks @dkalinichenko-js that's a good point. I've flipped the condition to be opt-in but left If opam-repo maintainers prefer the other way, they can cherry-pick the previous commit :-) |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build failure on ppc64 (example) and s390x (example) is the following:
Looking at the relevant code (as I wanted to know whether this is also the case in v0.16 - the code is quite different so it probably isn't) in https://github.com/janestreet/core_unix/blob/v0.17/time_stamp_counter/src/time_stamp_counter_stubs.c#L33-L47 this is due to the function only defined on x86, amd64 and arm64, so maybe it would make even more sense flip the availability condition to these three architectures instead?